Template some config settings by mohag · Pull Request #53 · kafbat/helm-charts

mohag · 2025-09-01T14:51:46Z

Template the config settings that can be used to configure the cluster that kafka-ui talks to.

Happened to clean up a bit of trailing whitespace.

Partially addresses #52. (the parts that I need and a few similar settings)

Summary by CodeRabbit

Bug Fixes
- Improved Helm template rendering so environment variables, config maps/secrets, ingress hosts, and volume/mount settings are properly evaluated, quoted, and substituted during deployment to prevent misconfiguration.
Chores
- Bumped Helm chart version to 1.6.4.

Haarolean · 2026-03-28T16:28:16Z

@coderabbitai review

coderabbitai · 2026-03-28T16:30:14Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai · 2026-03-28T16:30:19Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bd0fa83b-1001-457f-ba19-f36c55ca0c67

📥 Commits

Reviewing files that changed from the base of the PR and between dce4d9e and 0ebad22.

📒 Files selected for processing (2)

charts/kafka-ui/templates/deployment.yaml
charts/kafka-ui/templates/ingress.yaml

🚧 Files skipped from review as they are similar to previous changes (2)

charts/kafka-ui/templates/ingress.yaml
charts/kafka-ui/templates/deployment.yaml

📝 Walkthrough

Walkthrough

Helm chart version incremented to 1.6.4. Deployment and Ingress templates now render several user-supplied values with Helm tpl and emit many evaluated strings wrapped in quote; minor YAML formatting normalized.

Changes

Cohort / File(s)	Summary
Chart metadata `charts/kafka-ui/Chart.yaml`	Chart `version` updated from `1.6.3` to `1.6.4`.
Deployment template `charts/kafka-ui/templates/deployment.yaml`	Applied `tpl` rendering to user-supplied YAML (`.Values.env`, `.Values.volumeMounts`, `.Values.volumes`) via `tpl (toYaml .) $`; ran names/keys for YAML app config, `envs.secretMappings`, `envs.configMappings`, and `envFrom` existing config/secret through `tpl` and `quote`; preserved `required` checks inside `tpl`; minor `configMap` YAML normalization.
Ingress template `charts/kafka-ui/templates/ingress.yaml`	Ingress `spec.tls[].hosts` and `spec.rules[].host` now emit evaluated host values using `tpl` and `quote` (e.g., `{{ tpl .Values.ingress.host .

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐇 I hopped through templates, soft and spry,
tpl and quotes made hosts comply,
Bumped the chart to one six four,
Env and volumes tweaked once more,
A tiny hop — YAML sigh ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Template some config settings' is vague and does not clearly convey the specific changes made to the Helm chart templates.	Use a more descriptive title that specifies which configuration settings are being templated, such as 'Add template rendering for ingress hosts and volume configuration' or similar.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 2

🧹 Nitpick comments (1)

charts/kafka-ui/templates/deployment.yaml (1)

102-102: Quote templated resource names for YAML scalar safety and consistency.

Line 94 already quotes templated existingConfigMap; doing the same for Line 102, Line 171, and Line 176 avoids edge-case YAML coercion.

♻️ Proposed refactor

-                name: {{ tpl .Values.existingSecret . }}
+                name: {{ tpl .Values.existingSecret . | quote }}
...
-            name: {{ tpl .Values.yamlApplicationConfigConfigMap.name . }}
+            name: {{ tpl .Values.yamlApplicationConfigConfigMap.name . | quote }}
...
-            secretName: {{ tpl .Values.yamlApplicationConfigSecret.name . }}
+            secretName: {{ tpl .Values.yamlApplicationConfigSecret.name . | quote }}

Also applies to: 171-171, 176-176

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@charts/kafka-ui/templates/deployment.yaml` at line 102, The YAML scalar for
templated resource names should be quoted to avoid coercion issues: update the
occurrences that use the tpl helper with .Values.existingSecret (and the other
two occurrences noted for existingConfigMap/existingSecret) so they are rendered
as quoted strings; for example change name: {{ tpl .Values.existingSecret . }}
to name: "{{ tpl .Values.existingSecret . }}" and do the same for the other
templated instances (the tpl usages around existingConfigMap and existingSecret
at the referenced locations).

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@charts/kafka-ui/templates/deployment.yaml`:
- Around line 70-72: The Helm template pipelines call tpl before default which
can fail when keyName is unset; change the pipelines to apply default first then
pass that to tpl so the fallback "config.yml" is used: for both occurrences
referencing .Values.yamlApplicationConfigConfigMap.keyName and
.Values.yamlApplicationConfigSecret.keyName, wrap each keyName with default
"config.yml" (i.e. default .Values...keyName "config.yml") and then call tpl on
that result instead of tpl on the raw keyName.
- Around line 160-162: The volumes block misuses tpl on the object
.Values.volumes which stringifies it and breaks YAML; change the block to mirror
the env pattern (use with .Values.volumes and pass the object directly to toYaml
then nindent) instead of applying tpl — update the template surrounding
.Values.volumes so it uses {{- with .Values.volumes }} then {{- toYaml . |
nindent 8 }} and {{- end }}, leaving tpl only for actual template strings.

---

Nitpick comments:
In `@charts/kafka-ui/templates/deployment.yaml`:
- Line 102: The YAML scalar for templated resource names should be quoted to
avoid coercion issues: update the occurrences that use the tpl helper with
.Values.existingSecret (and the other two occurrences noted for
existingConfigMap/existingSecret) so they are rendered as quoted strings; for
example change name: {{ tpl .Values.existingSecret . }} to name: "{{ tpl
.Values.existingSecret . }}" and do the same for the other templated instances
(the tpl usages around existingConfigMap and existingSecret at the referenced
locations).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d1aaecda-e71b-4057-8335-5bd4c2553eba

📥 Commits

Reviewing files that changed from the base of the PR and between eace7b6 and f28acc1.

📒 Files selected for processing (2)

charts/kafka-ui/Chart.yaml
charts/kafka-ui/templates/deployment.yaml

Haarolean

please address coderabbit comments

mohag · 2026-04-08T11:42:41Z

please address coderabbit comments

I'll have a look over the next few days. (I likely need to test the issues and fixes)

…ing the 'tpl' function

mohag · 2026-04-16T07:54:21Z

@coderabbitai review

coderabbitai · 2026-04-16T07:54:30Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@charts/kafka-ui/templates/deployment.yaml`:
- Around line 100-102: The templated secret name produced by tpl
(.Values.existingSecret .) is emitted as an unquoted YAML scalar which can be
mis-parsed for values like "on"/"yes"/"true"; update the deployment template to
emit a quoted string by wrapping the tpl call with Helm's quote function (i.e.,
use quote (tpl .Values.existingSecret .)) for the secretRef.name so the rendered
name is always a proper YAML string; mirror the same quoting approach used for
existingConfigMap to ensure consistency.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a0959b64-2cb9-4d65-b6b7-07c3a1b09659

📥 Commits

Reviewing files that changed from the base of the PR and between b9c2ecf and 7488f09.

📒 Files selected for processing (2)

charts/kafka-ui/Chart.yaml
charts/kafka-ui/templates/deployment.yaml

✅ Files skipped from review due to trivial changes (1)

charts/kafka-ui/Chart.yaml

mohag · 2026-04-16T08:01:02Z

I'm not sure where to view the requested changes. (I did rebase on main to get rid of the conflicts, not sure if that got rid of them or if it was just the CodeRabbit issues)

coderabbitai · 2026-04-16T11:53:54Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

mohag · 2026-04-16T11:54:46Z

@coderabbitai review

coderabbitai · 2026-04-16T11:54:53Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

mohag · 2026-04-16T11:55:33Z

I thought the edit did not trigger it, deleted and then posted the correct message again, so probably hitting the rate limit again... Need to learn to refresh the issue to be sure I see the latest comments.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@charts/kafka-ui/templates/deployment.yaml`:
- Around line 173-181: The template currently calls tpl on
.Values.yamlApplicationConfigConfigMap.name and
.Values.yamlApplicationConfigSecret.name without validating presence; update
those tpl calls to use the required function around the name keys so Helm will
emit clear errors if name is missing (match the pattern already used elsewhere
in this file for yamlApplicationConfigConfigMap/name and
yamlApplicationConfigSecret/name), keeping the surrounding keys
(kafka-ui-yaml-conf-configmap and kafka-ui-yaml-conf-secret) intact and quoting
the result as before.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ccb3aa4c-0c5e-4c4c-9b8a-22da09a82341

📥 Commits

Reviewing files that changed from the base of the PR and between dce4d9e and 84f6fef.

📒 Files selected for processing (2)

charts/kafka-ui/templates/deployment.yaml
charts/kafka-ui/templates/ingress.yaml

✅ Files skipped from review due to trivial changes (1)

charts/kafka-ui/templates/ingress.yaml

mohag · 2026-04-20T10:41:50Z

@coderabbitai review

coderabbitai · 2026-04-20T10:41:56Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

mohag requested a review from a team as a code owner September 1, 2025 14:51

coderabbitai bot reviewed Mar 28, 2026

View reviewed changes

Comment thread charts/kafka-ui/templates/deployment.yaml Outdated

Comment thread charts/kafka-ui/templates/deployment.yaml Outdated

Haarolean requested changes Apr 2, 2026

View reviewed changes

Gert van den Berg added 2 commits April 15, 2026 17:41

Template config settings that can configure clusters to connect to us…

0b66ea1

…ing the 'tpl' function

Fixes for templating issues identified by CodeRabbit

7488f09

mohag force-pushed the main branch from b9c2ecf to 7488f09 Compare April 15, 2026 15:42

coderabbitai bot reviewed Apr 16, 2026

View reviewed changes

Comment thread charts/kafka-ui/templates/deployment.yaml Outdated

mohag requested a review from Haarolean April 16, 2026 08:00

Quote more templated fields to avoid potential issues

84f6fef

mohag force-pushed the main branch from dce4d9e to 84f6fef Compare April 16, 2026 09:45

coderabbitai bot reviewed Apr 16, 2026

View reviewed changes

Comment thread charts/kafka-ui/templates/deployment.yaml Outdated

Add warnings about missing values

0ebad22

Conversation

mohag commented Sep 1, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

Haarolean commented Mar 28, 2026

Uh oh!

coderabbitai bot commented Mar 28, 2026

Uh oh!

coderabbitai bot commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 inconclusive)

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Haarolean left a comment

Choose a reason for hiding this comment

Uh oh!

mohag commented Apr 8, 2026

Uh oh!

mohag commented Apr 16, 2026

Uh oh!

coderabbitai bot commented Apr 16, 2026

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mohag commented Apr 16, 2026

Uh oh!

coderabbitai bot commented Apr 16, 2026

Uh oh!

mohag commented Apr 16, 2026

Uh oh!

coderabbitai bot commented Apr 16, 2026

Uh oh!

mohag commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mohag commented Apr 20, 2026

Uh oh!

coderabbitai bot commented Apr 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mohag commented Sep 1, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 28, 2026 •

edited

Loading

mohag commented Apr 16, 2026 •

edited

Loading